Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1727)

Unified Diff: android_webview/browser/aw_cookie_access_policy.cc

Issue 2397393002: Provide child/frame IDs for WebSocket handshake request (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/browser/aw_cookie_access_policy.cc
diff --git a/android_webview/browser/aw_cookie_access_policy.cc b/android_webview/browser/aw_cookie_access_policy.cc
index 1dc3ba979a8d3cc3630ba83094c3a5f5fb291ad4..f14d09f69f3d58965f1f60957e5eb4d3c8a59430 100644
--- a/android_webview/browser/aw_cookie_access_policy.cc
+++ b/android_webview/browser/aw_cookie_access_policy.cc
@@ -10,11 +10,13 @@
#include "base/logging.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/resource_request_info.h"
+#include "content/public/browser/websocket_handshake_request_info.h"
#include "net/base/net_errors.h"
using base::AutoLock;
using content::BrowserThread;
using content::ResourceRequestInfo;
+using content::WebSocketHandshakeRequestInfo;
using net::StaticCookiePolicy;
namespace android_webview {
@@ -57,12 +59,21 @@ bool AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies(
bool AwCookieAccessPolicy::GetShouldAcceptThirdPartyCookies(
const net::URLRequest& request) {
+ int child_id = 0;
+ int frame_id = 0;
const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(&request);
- if (!info) {
- return false;
+ if (info) {
+ child_id = info->GetChildID();
+ frame_id = info->GetRenderFrameID();
+ } else {
+ const WebSocketHandshakeRequestInfo* websocket_info =
+ WebSocketHandshakeRequestInfo::ForRequest(&request);
+ if (!websocket_info)
+ return false;
+ child_id = websocket_info->GetChildId();
+ frame_id = websocket_info->GetRenderFrameId();
}
- return GetShouldAcceptThirdPartyCookies(info->GetChildID(),
- info->GetRenderFrameID());
+ return GetShouldAcceptThirdPartyCookies(child_id, frame_id);
}
bool AwCookieAccessPolicy::OnCanGetCookies(const net::URLRequest& request,
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698