Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 2397373004: [regexp] Remove unused InternalPackedArray (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Remove unused InternalPackedArray Committed: https://crrev.com/7d336218bf01984f8526c387ea9c0614a451ad34 Cr-Commit-Position: refs/heads/master@{#40130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/js/regexp.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
gsathya
4 years, 2 months ago (2016-10-07 18:55:40 UTC) #4
adamk
Is this even constructed anywhere? Can we remove the whole concept?
4 years, 2 months ago (2016-10-07 18:57:17 UTC) #5
gsathya
On 2016/10/07 18:57:17, adamk wrote: > Is this even constructed anywhere? Can we remove the ...
4 years, 2 months ago (2016-10-07 19:02:34 UTC) #6
adamk
No need for a separate patch, let's remove them all at once.
4 years, 2 months ago (2016-10-07 19:03:53 UTC) #7
gsathya
On 2016/10/07 19:03:53, adamk wrote: > No need for a separate patch, let's remove them ...
4 years, 2 months ago (2016-10-08 00:58:55 UTC) #10
adamk
just removing the import lgtm
4 years, 2 months ago (2016-10-10 16:14:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397373004/1
4 years, 2 months ago (2016-10-10 16:24:27 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 16:57:37 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 16:58:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d336218bf01984f8526c387ea9c0614a451ad34
Cr-Commit-Position: refs/heads/master@{#40130}

Powered by Google App Engine
This is Rietveld 408576698