Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h

Issue 2397363002: Replace hand-written IDBObserverCallback with auto-generated code (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
index 208b8b1d2f3aa4523e00b24ee70ea638a7f332a7..c4f00fa330ed9104e23259f42cae4f71f01e72fe 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObserver.h
@@ -5,6 +5,7 @@
#ifndef IDBObserver_h
#define IDBObserver_h
+#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "modules/ModulesExport.h"
#include "platform/heap/Handle.h"
@@ -21,12 +22,15 @@ class IDBObserverInit;
class IDBTransaction;
struct WebIDBObservation;
-class MODULES_EXPORT IDBObserver final : public GarbageCollected<IDBObserver>,
- public ScriptWrappable {
+class MODULES_EXPORT IDBObserver final
+ : public GarbageCollectedFinalized<IDBObserver>,
+ public ScriptWrappable {
DEFINE_WRAPPERTYPEINFO();
public:
- static IDBObserver* create(IDBObserverCallback&, const IDBObserverInit&);
+ static IDBObserver* create(ScriptState*,
+ IDBObserverCallback*,
+ const IDBObserverInit&);
void removeObserver(int32_t id);
void onChange(int32_t id,
@@ -47,8 +51,9 @@ class MODULES_EXPORT IDBObserver final : public GarbageCollected<IDBObserver>,
DECLARE_TRACE();
private:
- IDBObserver(IDBObserverCallback&, const IDBObserverInit&);
+ IDBObserver(ScriptState*, IDBObserverCallback*, const IDBObserverInit&);
+ RefPtr<ScriptState> m_scriptState;
Member<IDBObserverCallback> m_callback;
bool m_transaction;
bool m_values;
« no previous file with comments | « third_party/WebKit/Source/modules/BUILD.gn ('k') | third_party/WebKit/Source/modules/indexeddb/IDBObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698