Replace hand-written IDBObserverCallback with auto-generated code

third_party/WebKit/Source/bindings/scripts/utilities.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Utility functions (file reading, simple IDL parsing by regexes) for IDL build.
 
 Design doc: http://www.chromium.org/developers/design-documents/idl-build
 """
 
 import os
@@ skipping 316 matching lines @@
             except Exception:
                 # If trouble unpickling, overwrite
                 pass
     with open(pickle_filename, 'w') as pickle_file:
         pickle.dump(data, pickle_file)
 
 
 ################################################################################
 # IDL parsing
 #
-# We use regular expressions for parsing; this is incorrect (Web IDL is not a
-# regular language), but simple and sufficient in practice.
+# TODO(bashi) We use regular expressions for parsing; this is incorrect
+# (Web IDL is not a regular language), and broken. Remove these functions and
+# always use the parser and ASTs.
 # Leading and trailing context (e.g. following '{') used to avoid false matches.
 ################################################################################
 
 def is_callback_interface_from_idl(file_contents):
     match = re.search(r'callback\s+interface\s+\w+\s*{', file_contents)
     return bool(match)
 
 
 def should_generate_impl_file_from_idl(file_contents):
     """True when a given IDL file contents could generate .h/.cpp files."""
     # FIXME: This would be error-prone and we should use AST rather than
     # improving the regexp pattern.
     match = re.search(r'(interface|dictionary|exception)\s+\w+', file_contents)
     return bool(match)
 
 
 def match_interface_extended_attributes_from_idl(file_contents):
     # Strip comments
     # re.compile needed b/c Python 2.6 doesn't support flags in re.sub
     single_line_comment_re = re.compile(r'//.*$', flags=re.MULTILINE)
     block_comment_re = re.compile(r'/\*.*?\*/', flags=re.MULTILINE | re.DOTALL)
     file_contents = re.sub(single_line_comment_re, '', file_contents)
     file_contents = re.sub(block_comment_re, '', file_contents)
 
-    match = re.search(r'\[(.*)\]\s*'

[bashi, 2016/10/07 07:07:26]

This regexp is totally broken and doesn't work following case :(

[ExperimentalCallbackFunction] callback foo = void ();
[...] interface { ... }

-                      r'((callback|partial)\s+)?'
-                      r'(interface|exception)\s+'
-                      r'\w+\s*'
-                      r'(:\s*\w+\s*)?'
-                      r'{',
-                      file_contents, flags=re.DOTALL)
+    match = re.search(
+        r'\[([^[]*)\]\s*'
+        r'(interface|callback\s+interface|partial\s+interface|exception)\s+'
+        r'\w+\s*'
+        r'(:\s*\w+\s*)?'
+        r'{',
+        file_contents, flags=re.DOTALL)
     return match
 
-
 def get_interface_extended_attributes_from_idl(file_contents):
     match = match_interface_extended_attributes_from_idl(file_contents)
     if not match:
         return {}
 
     extended_attributes_string = match.group(1)
     extended_attributes = {}
     # FIXME: this splitting is WRONG: it fails on extended attributes where lists of
     # multiple values are used, which are seperated by a comma and a space.
     parts = [extended_attribute.strip()
@@ skipping 127 matching lines @@
 
         # Remember an open brace.
         match = re_last_brace.search(line)
         was_open_brace = (match and match.group('last') == '{' and 'namespace' not in line)
 
     # Let |'\n'.join| emit the last newline.
     if output:
         output.append('')
 
     return '\n'.join(output)