Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2397353002: Purge references of "Mojo Application" from comments & var names. (Closed)

Created:
4 years, 2 months ago by Ben Goodger (Google)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nona+watch_chromium.org, shuchen+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, tfarina, kalyank, darin (slow to review), James Su, jshin+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Purge references of "Mojo Application" from comments & var names. Replace with Service. TBR=rockot@chromium.org,tsepez@chromium.org Committed: https://crrev.com/eef69a404d883e27c53378bdafc3436a0c0b660c Cr-Commit-Position: refs/heads/master@{#423865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -248 lines) Patch
M ash/mus/app_list_presenter_mus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/i18n/icu_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/leveldb/env_mojo.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mus.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/embedder/README.md View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/README.md View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/README.md View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/interface_endpoint_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/router.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/js/threading.js View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/public/interfaces/capabilities.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/public/interfaces/connector.mojom View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/common/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
M services/shell/runner/host/child_process.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M services/shell/runner/host/child_process_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/child_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/runner/host/in_process_native_runner.h View 4 chunks +9 lines, -9 lines 0 comments Download
M services/shell/runner/host/in_process_native_runner.cc View 3 chunks +21 lines, -21 lines 0 comments Download
D services/shell/runner/host/native_application_support.h View 1 chunk +0 lines, -38 lines 0 comments Download
D services/shell/runner/host/native_application_support.cc View 1 chunk +0 lines, -105 lines 0 comments Download
A services/shell/runner/host/native_library_runner.h View 1 chunk +38 lines, -0 lines 0 comments Download
A + services/shell/runner/host/native_library_runner.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M services/shell/runner/init.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/shell/tests/connect/connect_test_package.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/shell/tests/connect/connect_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M services/tracing/public/cpp/provider.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M services/ui/demo/mus_demo.h View 1 chunk +3 lines, -3 lines 0 comments Download
M services/ui/public/interfaces/surface.mojom View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/views_mus_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397353002/1
4 years, 2 months ago (2016-10-07 04:05:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/156159)
4 years, 2 months ago (2016-10-07 05:57:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397353002/1
4 years, 2 months ago (2016-10-07 15:06:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 15:43:18 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:47:10 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eef69a404d883e27c53378bdafc3436a0c0b660c
Cr-Commit-Position: refs/heads/master@{#423865}

Powered by Google App Engine
This is Rietveld 408576698