Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2397333002: Change layerTreeAsText to default to layer lists. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
pdr.
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, mstensho (USE GERRIT), pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change layerTreeAsText to default to layer lists. BUG=647831 Committed: https://crrev.com/27b6c856a60c79ab78acad988416a72a08274ee8 Cr-Commit-Position: refs/heads/master@{#424089}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Patch Set 5 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1047 lines, -234 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +907 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/animation/hidden-composited.html View 1 1 chunk +9 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/change-preferCompositingToLCDText-setting.html View 1 1 chunk +8 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/overlap-child-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/stacking-context-overlap.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-added.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-overlap.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/translatez-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/ancestor-with-clip-path.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/avoid-ancestor-clip-for-scroll-children.html View 1 1 chunk +9 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/descendant-with-clip-path.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/opt-in-if-composited.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-opaque-to-transparent.html View 1 3 chunks +2 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-background-transparent-to-opaque.html View 1 2 chunks +2 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html View 1 2 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background-will-change.html View 1 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-pointer-events-toggle.html View 1 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-transparent-background.html View 1 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/resources/composited-scroll.js View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/scroller-with-border-radius.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/universal-accelerated-overflow-scroll.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rendering-contexts.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/do-not-squash-scroll-child-with-composited-descendants.html View 1 1 chunk +15 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-animated-layers.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-blend-mode.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-with-scale-transform.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/csspaint/resources/test-runner-invalidation-logging.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/CompositorProxy/proxy-forces-layer.html View 1 2 3 4 1 chunk +13 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/multicol/composited-layer.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-before-text-node-update.html View 1 2 3 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/margin.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/obscured-background-no-repaint.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/resources/text-based-repaint.js View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/subpixel-shadow-included-in-invalidation.html View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerClient.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
chrishtr
Example rebaselines (ignore the timeouts at the end, fixed in this patchset): https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/312443/layout-test-results/results.html
4 years, 2 months ago (2016-10-08 00:03:38 UTC) #12
pdr.
LGTM
4 years, 2 months ago (2016-10-08 00:12:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397333002/60001
4 years, 2 months ago (2016-10-08 00:20:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/308288)
4 years, 2 months ago (2016-10-08 02:06:36 UTC) #18
chrishtr
Fixed fast/dom/CompositorProxy/proxy-forces-layer.html.
4 years, 2 months ago (2016-10-09 00:47:43 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397333002/80001
4 years, 2 months ago (2016-10-09 00:48:00 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-09 01:56:22 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-09 01:59:05 UTC) #25
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/27b6c856a60c79ab78acad988416a72a08274ee8
Cr-Commit-Position: refs/heads/master@{#424089}

Powered by Google App Engine
This is Rietveld 408576698