Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Issue 2397273002: Show a custom page info bubble for chrome-devtools:// URLs (Closed)
Patch Set: Fix mac build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
index a6a2128724f92a3941a32e8b7fbfedf41b6704d3..0da38f20492f1595f2c6926735717021c3e8839b 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm
@@ -185,6 +185,7 @@ NSPoint AnchorPointForWindow(NSWindow* parent) {
bool IsInternalURL(const GURL& url) {
return url.SchemeIs(content::kChromeUIScheme) ||
+ url.SchemeIs(content::kChromeDevToolsScheme) ||
url.SchemeIs(extensions::kExtensionScheme) ||
url.SchemeIs(content::kViewSourceScheme);
}
@@ -260,7 +261,8 @@ bool IsInternalURL(const GURL& url) {
text = IDS_PAGE_INFO_VIEW_SOURCE_PAGE;
// view-source scheme uses the same icon as chrome:// pages.
icon = IDR_PRODUCT_LOGO_16;
- } else if (!url.SchemeIs(content::kChromeUIScheme)) {
+ } else if (!url.SchemeIs(content::kChromeUIScheme) &&
+ !url.SchemeIs(content::kChromeDevToolsScheme)) {
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698