Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2397273002: Show a custom page info bubble for chrome-devtools:// URLs (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index 914ce96d88e626900c329b620da2c5a75a58689a..ac64aec7a7da5edc97eb9ef8fa9dd44bdd3c8674 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -396,6 +396,15 @@ void WebsiteSettings::OnRevokeSSLErrorBypassButtonPressed() {
void WebsiteSettings::Init(
const GURL& url,
const SecurityStateModel::SecurityInfo& security_info) {
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+ // On desktop, internal URLs aren't handled by this class. Instead, a
+ // custom and simpler popup is shown.
+ DCHECK(!url.SchemeIs(content::kChromeUIScheme) &&
+ !url.SchemeIs(content::kChromeDevToolsScheme) &&
+ !url.SchemeIs(content::kViewSourceScheme) &&
+ !url.SchemeIs(content_settings::kExtensionScheme));
+#endif
+
bool isChromeUINativeScheme = false;
#if BUILDFLAG(ANDROID_JAVA_UI)
isChromeUINativeScheme = url.SchemeIs(chrome::kChromeUINativeScheme);

Powered by Google App Engine
This is Rietveld 408576698