Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2397263003: arc: Remove IntentHelperInstance::HandleUrlListDeprecated. (Closed)

Created:
4 years, 2 months ago by Daniel Erat
Modified:
4 years, 2 months ago
Reviewers:
Yusuke Sato, dcheng, kinaba
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, darin (slow to review), qsr+mojo_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Remove IntentHelperInstance::HandleUrlListDeprecated. Remove IntentHelperInstance's HandleUrlListDeprecated method. Chrome stopped calling it in https://codereview.chromium.org/2392253003/. BUG=647802 Committed: https://crrev.com/ca145c8a83b4c38726d09412e9a716764fadb980 Cr-Commit-Position: refs/heads/master@{#423798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M components/arc/common/intent_helper.mojom View 1 chunk +0 lines, -5 lines 0 comments Download
M components/arc/test/fake_intent_helper_instance.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/arc/test/fake_intent_helper_instance.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Daniel Erat
is there a canonical place to check to determine when it's safe to remove a ...
4 years, 2 months ago (2016-10-07 00:57:45 UTC) #2
kinaba
lgtm On 2016/10/07 00:57:45, Daniel Erat wrote: > is there a canonical place to check ...
4 years, 2 months ago (2016-10-07 01:08:09 UTC) #5
dcheng
rs lgtm for mojom (yay for code deletion)
4 years, 2 months ago (2016-10-07 03:29:58 UTC) #8
Yusuke Sato
lgtm
4 years, 2 months ago (2016-10-07 03:35:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397263003/1
4 years, 2 months ago (2016-10-07 05:04:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 05:09:13 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 05:10:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca145c8a83b4c38726d09412e9a716764fadb980
Cr-Commit-Position: refs/heads/master@{#423798}

Powered by Google App Engine
This is Rietveld 408576698