Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2397253002: [turbofan] CheckedTaggedToInt32 doesn't distinguish undefined and hole. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] CheckedTaggedToInt32 doesn't distinguish undefined and hole. R=mvstanton@chromium.org BUG=v8:5267 Committed: https://crrev.com/78f16b39ca5462f5a58bd10d751508b3d22e8864 Cr-Commit-Position: refs/heads/master@{#40073}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/simplified-operator-reducer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-06 18:51:06 UTC) #1
mvstanton
lgtm
4 years, 2 months ago (2016-10-07 07:57:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397253002/1
4 years, 2 months ago (2016-10-07 08:59:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 09:10:25 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 09:10:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78f16b39ca5462f5a58bd10d751508b3d22e8864
Cr-Commit-Position: refs/heads/master@{#40073}

Powered by Google App Engine
This is Rietveld 408576698