Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2397243004: Prune deprecated functions from InsertLinebreakCommand (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune deprecated functions from InsertLinebreakCommand BUG=647219, 651373 Committed: https://crrev.com/530e41279924e07a77a1164a6e1cf20e28cd63c3 Cr-Commit-Position: refs/heads/master@{#423823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp View 6 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-07 08:54:11 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-07 09:15:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397243004/1
4 years, 2 months ago (2016-10-07 09:15:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 09:30:07 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 09:31:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/530e41279924e07a77a1164a6e1cf20e28cd63c3
Cr-Commit-Position: refs/heads/master@{#423823}

Powered by Google App Engine
This is Rietveld 408576698