Fix trace parameter showing gibberish.

Fix trace parameter showing gibberish.

The async trace call affected by this CL used to add two |char *| arguments to
the event of type which are *not* copied and were -- one potentially the other
always -- destroyed before they were actually used at the event end. This caused
gibberish to be sometimes presented in the trace report view.

This CL fixes that by converting them to std:string values which are always
stored as copies.

BUG=645686
Committed: https://crrev.com/44ec5ba689f1949babb12bd10f5e9b38eb05f257
Cr-Commit-Position: refs/heads/master@{#424470}

[carlosk, 2016-10-07 01:38:58]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 01:39:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 02:22:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 02:22:55]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[carlosk, 2016-10-07 18:42:00]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 18:42:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 19:26:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 19:26:15]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[carlosk, 2016-10-07 23:40:45]

The CQ bit was checked by carlosk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 23:40:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[carlosk, 2016-10-08 00:04:50]

carlosk@chromium.org changed reviewers:
+ rdsmith@chromium.org

[carlosk, 2016-10-08 00:04:51]

rdsmith@: PTAL.

[commit-bot: I haz the power, 2016-10-08 01:48:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-08 01:48:23]

Dry run: This issue passed the CQ dry run.

[asanka, 2016-10-11 14:26:59]

asanka@chromium.org changed reviewers:
+ asanka@chromium.org

[asanka, 2016-10-11 14:27:00]

lgtm

[carlosk, 2016-10-11 16:44:00]

The CQ bit was checked by carlosk@chromium.org

[commit-bot: I haz the power, 2016-10-11 16:44:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:30:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 17:32:32]

Description was changed from

==========
Fix trace parameter showing gibberish.

The async trace call affected by this CL used to add two |char *| arguments to
the event of type which are *not* copied and were -- one potentially the other
always -- destroyed before they were actually used at the event end. This caused
gibberish to be sometimes presented in the trace report view.

This CL fixes that by converting them to std:string values which are always
stored as copies.

BUG=645686
==========

to

==========
Fix trace parameter showing gibberish.

The async trace call affected by this CL used to add two |char *| arguments to
the event of type which are *not* copied and were -- one potentially the other
always -- destroyed before they were actually used at the event end. This caused
gibberish to be sometimes presented in the trace report view.

This CL fixes that by converting them to std:string values which are always
stored as copies.

BUG=645686

Committed: https://crrev.com/44ec5ba689f1949babb12bd10f5e9b38eb05f257
Cr-Commit-Position: refs/heads/master@{#424470}
==========

[commit-bot: I haz the power, 2016-10-11 17:32:33]

Patchset 3 (id:??) landed as
https://crrev.com/44ec5ba689f1949babb12bd10f5e9b38eb05f257
Cr-Commit-Position: refs/heads/master@{#424470}