Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2397233003: Move CollectionIndexCache.h from core/html/ to core/dom/. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CollectionIndexCache.h from core/html/ to core/dom/. core/dom/ChildNodeList depends on it. We should put it to core/dom/ because core/dom is a lower layer. This CL has no behavior changes. Committed: https://crrev.com/3cc24b58938a8357176b1ee4329a0f8b8f904628 Cr-Commit-Position: refs/heads/master@{#424467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -217 lines) Patch
M third_party/WebKit/Source/core/dom/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ChildNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/dom/CollectionIndexCache.h View 1 chunk +2 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/core/html/CollectionIndexCache.h View 1 chunk +0 lines, -215 lines 0 comments Download
M third_party/WebKit/Source/core/html/CollectionItemsCache.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkent
hayato@, would you review this please?
4 years, 2 months ago (2016-10-07 02:14:11 UTC) #6
hayato
lgtm
4 years, 2 months ago (2016-10-11 08:29:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397233003/1
4 years, 2 months ago (2016-10-11 13:48:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:17:33 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:20:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cc24b58938a8357176b1ee4329a0f8b8f904628
Cr-Commit-Position: refs/heads/master@{#424467}

Powered by Google App Engine
This is Rietveld 408576698