Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 2397223002: [stubs] Port NumberToString stub to TF (Closed)

Created:
4 years, 2 months ago by danno
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Port NumberToStringSub to Turbofan In the process, also fix a merge hiccup that clobbered https://codereview.chromium.org/2003663002/ back in May. BUG=chromium:608675 LOG=N Committed: https://crrev.com/e0741946cb255a4e59e17a4ab3bf347f2b225da5 Cr-Commit-Position: refs/heads/master@{#40085}

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Patch Set 3 : Latest #

Patch Set 4 : Remove dead code #

Patch Set 5 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -24 lines) Patch
M src/code-stub-assembler.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stub-assembler.cc View 1 2 3 4 1 chunk +79 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 2 chunks +7 lines, -6 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/compiler/schedule.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (23 generated)
danno
ptal
4 years, 2 months ago (2016-10-07 08:45:47 UTC) #15
Igor Sheludko
lgtm
4 years, 2 months ago (2016-10-07 09:00:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397223002/60001
4 years, 2 months ago (2016-10-07 10:54:31 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/25924)
4 years, 2 months ago (2016-10-07 10:59:45 UTC) #22
Michael Starzinger
LGTM (rubber-stamp of "compiler", didn't look at the rest).
4 years, 2 months ago (2016-10-07 11:57:56 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397223002/80001
4 years, 2 months ago (2016-10-07 11:58:46 UTC) #27
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-07 12:28:56 UTC) #29
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 12:29:19 UTC) #31
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e0741946cb255a4e59e17a4ab3bf347f2b225da5
Cr-Commit-Position: refs/heads/master@{#40085}

Powered by Google App Engine
This is Rietveld 408576698