LayoutTests/fast/text/international/unicode-bidi-isolate-nested-with-removes-not-adjacent.html - Issue 23972003: Update containtingIsolate to go back all the way to top isolate from current

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text/international/unicode-bidi-isolate-nested-with-removes-not-adjacent.html

Issue 23972003: Update containtingIsolate to go back all the way to top isolate from current (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/text/international/unicode-bidi-isolate-nested-with-removes-not-adjacent-expected.txt » ('j') | Source/core/rendering/InlineIterator.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- This tests for regression of https://crbug.com/279277 where non-adjacent, n ested isolates caused a use-after-free if the elements were later removed. -->
	leviw_travelin_and_unemployed 2013/09/04 22:00:24 <!doctype html>? <!doctype html>? jww 2013/09/04 22:37:26 I'm happy to make all of the changes here, but thi Show quoted text On 2013/09/04 22:00:24, Levi wrote: > <!doctype html>? I'm happy to make all of the changes here, but this is directly copied from my already committed test "unicode-bidi-isolate-nested-with-removes.html". Should I change that one as well to match all of these comments? leviw_travelin_and_unemployed 2013/09/04 22:46:25 I'd say yes :) Show quoted text On 2013/09/04 22:37:26, jww wrote: > On 2013/09/04 22:00:24, Levi wrote: > > <!doctype html>? > > I'm happy to make all of the changes here, but this is directly copied from my > already committed test "unicode-bidi-isolate-nested-with-removes.html". Should I > change that one as well to match all of these comments? I'd say yes :) jww 2013/09/04 23:12:15 Done. Show quoted text On 2013/09/04 22:46:25, Levi wrote: > On 2013/09/04 22:37:26, jww wrote: > > On 2013/09/04 22:00:24, Levi wrote: > > > <!doctype html>? > > > > I'm happy to make all of the changes here, but this is directly copied from my > > already committed test "unicode-bidi-isolate-nested-with-removes.html". Should > I > > change that one as well to match all of these comments? > > I'd say yes :) Done.
	2 <script>

	3 function remove(node)
	leviw_travelin_and_unemployed 2013/09/04 22:00:24 This seems somewhat unnecessary. This seems somewhat unnecessary. jww 2013/09/04 22:37:26 See above response. Show quoted text On 2013/09/04 22:00:24, Levi wrote: > This seems somewhat unnecessary. See above response.
	4 {

	5 node.parentNode.removeChild(node);

	6 }

	7

	8 window.onload = function() {

	9 document.body.offsetTop;

	10 remove(b.lastChild);

	11 document.body.offsetTop;

	12 remove(a.nextSibling);

	13 document.body.offsetTop;

	14

	15 document.body.appendChild(document.createTextNode("PASS did not crash"));
	leviw_travelin_and_unemployed 2013/09/04 22:00:24 I'd probably just use document.write so "foo" and I'd probably just use document.write so "foo" and "bar" are no longer in the output. jww 2013/09/04 22:37:26 See above response. Show quoted text On 2013/09/04 22:00:24, Levi wrote: > I'd probably just use document.write so "foo" and "bar" are no longer in the > output. See above response.
	16 }

	17 </script>

	18

	19 <body>

	20 <div id="a">foo</div><div>baz</div><div></div>

	21 <div>

	22 <output>

	23 <span>

	24 <output>bar</output>

	25 <span id="b">

	26 <span>

	27 <div style="display:inline-block"></div>

	28 <br><br>

	29 </span>

	30 </span>

	31 </span>

	32 </output>

	33 </div>

	34 </body>

	35

	36 <script>

	37 if (window.testRunner)

	38 testRunner.dumpAsText();

	39 </script>

OLD	NEW