Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2397193003: PPC/s390: [turbofan] JSGenericLowering mostly uses builtins instead of code stubs now (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [turbofan] JSGenericLowering mostly uses builtins instead of code stubs now Port 0c168a90ffc34e3e4defee0c1cc39fe522dae2c0 R=tebbi@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/411aa27a475cc2d0c86bc88ece892eb391e2fd01 Cr-Commit-Position: refs/heads/master@{#40059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/crankshaft/s390/lithium-codegen-s390.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
JaideepBajwa
lgtm
4 years, 2 months ago (2016-10-06 18:38:46 UTC) #1
Tobias Tebbi
thanks, lgtm too
4 years, 2 months ago (2016-10-06 19:00:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397193003/1
4 years, 2 months ago (2016-10-06 19:04:13 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-06 19:04:14 UTC) #7
john.yan
lgtm
4 years, 2 months ago (2016-10-06 19:06:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397193003/1
4 years, 2 months ago (2016-10-06 19:10:23 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 19:39:20 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 19:39:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/411aa27a475cc2d0c86bc88ece892eb391e2fd01
Cr-Commit-Position: refs/heads/master@{#40059}

Powered by Google App Engine
This is Rietveld 408576698