Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2397173002: Check for valid context in AudioOutputDeviceClient::from. (Closed)

Created:
4 years, 2 months ago by Guido Urdaneta
Modified:
4 years, 2 months ago
Reviewers:
haraken, foolip
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for valid context in AudioOutputDeviceClient::from. BUG=652214 Committed: https://crrev.com/b4bd6dcf5c7d86f7a50aa401652c166cfc23f442 Cr-Commit-Position: refs/heads/master@{#423544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Guido Urdaneta
Hi, PTAL
4 years, 2 months ago (2016-10-06 14:09:17 UTC) #3
foolip
lgtm
4 years, 2 months ago (2016-10-06 14:10:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397173002/1
4 years, 2 months ago (2016-10-06 14:11:13 UTC) #6
haraken
LGTM (This should have been caused by my change to clear LifecycleObserver::m_context when the context ...
4 years, 2 months ago (2016-10-06 14:14:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 15:39:00 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:40:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b4bd6dcf5c7d86f7a50aa401652c166cfc23f442
Cr-Commit-Position: refs/heads/master@{#423544}

Powered by Google App Engine
This is Rietveld 408576698