Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2397153004: Issue 27536. Quick Fix for 'Avoid using braces in interpolation when not needed'. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 3 chunks +17 lines, -0 lines 1 comment Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-07 18:48:19 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2397153004/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart File pkg/analysis_server/lib/src/services/correction/fix_internal.dart (right): https://codereview.chromium.org/2397153004/diff/1/pkg/analysis_server/lib/src/services/correction/fix_internal.dart#newcode2295 pkg/analysis_server/lib/src/services/correction/fix_internal.dart:2295: void _addLintRemoveInterpolationBraces() { Remove "Lint" from the name? ...
4 years, 2 months ago (2016-10-07 18:57:56 UTC) #2
scheglov
4 years, 2 months ago (2016-10-07 19:51:10 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
831d3119f22003c75c604ec545a7a49991a2e5f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698