Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 2397153003: Ensure web page clicks off SERP are loaded in Chrome. (Closed)

Created:
4 years, 2 months ago by Maria
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure web page clicks off SERP are loaded in Chrome. SERP will dispatch intents directly to instant apps. If the user clicked on http/https link on SERP, it should not offer or launch instant apps. BUG=644772 Committed: https://crrev.com/4fdb89271ce688a138fd337c781482f5d06e6941 Cr-Commit-Position: refs/heads/master@{#423734}

Patch Set 1 #

Patch Set 2 : Refactor SERP check out. #

Patch Set 3 : Fix the check for Google Search URL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegate.java View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 2 3 chunks +19 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Maria
4 years, 2 months ago (2016-10-06 19:07:33 UTC) #2
Maria
On 2016/10/06 19:07:33, Maria wrote: FYI, the SERP check is public because a follow-on CL ...
4 years, 2 months ago (2016-10-06 20:02:17 UTC) #3
Maria
On 2016/10/06 20:02:17, Maria wrote: > On 2016/10/06 19:07:33, Maria wrote: > > FYI, the ...
4 years, 2 months ago (2016-10-06 21:05:38 UTC) #8
Ted C
lgtm
4 years, 2 months ago (2016-10-06 22:29:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397153003/40001
4 years, 2 months ago (2016-10-06 22:47:59 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 23:29:43 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 23:30:49 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4fdb89271ce688a138fd337c781482f5d06e6941
Cr-Commit-Position: refs/heads/master@{#423734}

Powered by Google App Engine
This is Rietveld 408576698