Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffect.h

Issue 2397113002: Move content up to KeyframeEffectReadOnly (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/KeyframeEffect.h
diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffect.h b/third_party/WebKit/Source/core/animation/KeyframeEffect.h
index b9b40c11c648a5c4ee1d39bbd882ede2b932d099..3fb0aadc7d0893cdc5c44a4dc7e9cd9c9527bd8d 100644
--- a/third_party/WebKit/Source/core/animation/KeyframeEffect.h
+++ b/third_party/WebKit/Source/core/animation/KeyframeEffect.h
@@ -33,21 +33,15 @@
#include "core/CoreExport.h"
#include "core/animation/AnimationEffectTiming.h"
-#include "core/animation/EffectInput.h"
#include "core/animation/EffectModel.h"
#include "core/animation/KeyframeEffectReadOnly.h"
-#include "core/animation/TimingInput.h"
-#include "platform/heap/Handle.h"
-#include "wtf/RefPtr.h"
namespace blink {
-class Dictionary;
class Element;
class ExceptionState;
class KeyframeEffectOptions;
class PropertyHandle;
-class SampledEffect;
// Represents the effect of an Animation on an Element's properties.
// http://w3c.github.io/web-animations/#keyframe-effect
@@ -84,61 +78,14 @@ class CORE_EXPORT KeyframeEffect final : public KeyframeEffectReadOnly {
bool isKeyframeEffect() const override { return true; }
- bool affects(PropertyHandle) const;
- const EffectModel* model() const { return m_model.get(); }
- EffectModel* model() { return m_model.get(); }
- void setModel(EffectModel* model) { m_model = model; }
- Element* target() const { return m_target; }
-
- void notifySampledEffectRemovedFromAnimationStack();
-
- bool isCandidateForAnimationOnCompositor(double animationPlaybackRate) const;
- // Must only be called once.
- bool maybeStartAnimationOnCompositor(int group,
- double startTime,
- double timeOffset,
- double animationPlaybackRate);
- bool hasActiveAnimationsOnCompositor() const;
- bool hasActiveAnimationsOnCompositor(CSSPropertyID) const;
- bool cancelAnimationOnCompositor();
- void restartAnimationOnCompositor();
- void cancelIncompatibleAnimationsOnCompositor();
- void pauseAnimationForTestingOnCompositor(double pauseTime);
-
- void attachCompositedLayers();
-
- void setCompositorAnimationIdsForTesting(
- const Vector<int>& compositorAnimationIds) {
- m_compositorAnimationIds = compositorAnimationIds;
- }
-
AnimationEffectTiming* timing() override;
- DECLARE_VIRTUAL_TRACE();
-
- protected:
- void applyEffects();
- void clearEffects();
- void updateChildrenAndEffects() const override;
- void attach(Animation*) override;
- void detach() override;
- void specifiedTimingChanged() override;
- double calculateTimeToEffectChange(bool forwards,
- double inheritedTime,
- double timeToNextIteration) const override;
- virtual bool hasIncompatibleStyle();
- bool hasMultipleTransformProperties() const;
-
private:
KeyframeEffect(Element*,
EffectModel*,
const Timing&,
KeyframeEffectReadOnly::Priority,
EventDelegate*);
-
- Vector<int> m_compositorAnimationIds;
-
- friend class AnimationAnimationV8Test;
suzyh_UTC10 (ex-contributor) 2016/10/07 00:46:00 Oh yes, I meant to comment on this. The AnimationA
};
DEFINE_TYPE_CASTS(KeyframeEffect,

Powered by Google App Engine
This is Rietveld 408576698