Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2397103002: Move SurfaceSequenceGenerator => cc/surfaces (Closed)

Created:
4 years, 2 months ago by Fady Samuel
Modified:
4 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SurfaceSequenceGenerator => cc/surfaces SurfaceSequenceGenerator is useful in mus in the short term and so this CL moves it somewhere where we can use it. BUG=647852 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/3439656732dc29f07bcc7800ff0226179ecde149 Cr-Commit-Position: refs/heads/master@{#423532}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Patch Set 3 : Remove export #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -98 lines) Patch
M cc/BUILD.gn View 3 chunks +1 line, -3 lines 0 comments Download
M cc/blimp/layer_tree_host_remote.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
A + cc/surfaces/surface_sequence_generator.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + cc/surfaces/surface_sequence_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
A + cc/surfaces/surface_sequence_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_in_process.h View 1 chunk +1 line, -1 line 0 comments Download
D cc/trees/surface_sequence_generator.h View 1 chunk +0 lines, -41 lines 0 comments Download
D cc/trees/surface_sequence_generator.cc View 1 chunk +0 lines, -19 lines 0 comments Download
D cc/trees/surface_sequence_generator_unittest.cc View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Fady Samuel
4 years, 2 months ago (2016-10-06 02:41:23 UTC) #4
ajuma
lgtm https://codereview.chromium.org/2397103002/diff/1/cc/surfaces/surface_sequence_generator.h File cc/surfaces/surface_sequence_generator.h (right): https://codereview.chromium.org/2397103002/diff/1/cc/surfaces/surface_sequence_generator.h#newcode21 cc/surfaces/surface_sequence_generator.h:21: class CC_EXPORT SurfaceSequenceGenerator { I think you want ...
4 years, 2 months ago (2016-10-06 13:43:20 UTC) #8
Fady Samuel
Thanks Ali! CQ'ing. https://codereview.chromium.org/2397103002/diff/1/cc/surfaces/surface_sequence_generator.h File cc/surfaces/surface_sequence_generator.h (right): https://codereview.chromium.org/2397103002/diff/1/cc/surfaces/surface_sequence_generator.h#newcode21 cc/surfaces/surface_sequence_generator.h:21: class CC_EXPORT SurfaceSequenceGenerator { On 2016/10/06 ...
4 years, 2 months ago (2016-10-06 13:48:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397103002/20001
4 years, 2 months ago (2016-10-06 13:49:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/141362) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 2 months ago (2016-10-06 13:52:26 UTC) #14
Fady Samuel
On 2016/10/06 13:52:26, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 2 months ago (2016-10-06 13:54:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2397103002/40001
4 years, 2 months ago (2016-10-06 13:57:09 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 15:01:46 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 15:04:21 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3439656732dc29f07bcc7800ff0226179ecde149
Cr-Commit-Position: refs/heads/master@{#423532}

Powered by Google App Engine
This is Rietveld 408576698