Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: sdk/lib/_internal/compiler/implementation/types/container_tracer.dart

Issue 23971013: Remove wrong handling of cascade calls in ContainerTracerVisitor. Its super class InferrerVisitor h… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/cascade2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/types/container_tracer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/types/container_tracer.dart (revision 27556)
+++ sdk/lib/_internal/compiler/implementation/types/container_tracer.dart (working copy)
@@ -498,29 +498,6 @@
return types.growableListType;
}
- // TODO(ngeoffray): Try to move the following two methods in
- // [InferrerVisitor].
- TypeMask visitCascadeReceiver(CascadeReceiver node) {
- return visit(node.expression);
- }
-
- TypeMask visitCascade(Cascade node) {
- Send send = node.expression;
- TypeMask result;
- bool isReceiver = visitAndCatchEscaping(() {
- result = visit(send.receiver);
- });
- if (send.asSendSet() != null) {
- handleSendSet(send, isReceiver);
- } else {
- handleDynamicSend(send, isReceiver);
- }
- if (isReceiver) {
- escaping = true;
- }
- return result;
- }
-
TypeMask visitSendSet(SendSet node) {
bool isReceiver = visitAndCatchEscaping(() {
visit(node.receiver);
« no previous file with comments | « no previous file | tests/language/cascade2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698