Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 23971010: roll gyp 1731:1732 (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

roll gyp 1731:1732 1732: ninja: Put generated sources in front of regular sources. BUG=280718 R=scottmg@chromium.org TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 3 months ago (2013-09-16 16:23:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/23971010/1
7 years, 3 months ago (2013-09-16 16:23:18 UTC) #2
scottmg
lgtm
7 years, 3 months ago (2013-09-16 16:51:41 UTC) #3
Nico
7 years, 3 months ago (2013-09-16 17:53:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r223356 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698