Issue 23971005: Show the mixed content shield UI even for HSTS hosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23971005: Show the mixed content shield UI even for HSTS hosts. (Closed)

Created:
7 years, 3 months ago by Chris Evans

Modified:
7 years, 3 months ago

Reviewers:
Lei Zhang, Tom Sepez

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Show the mixed content shield UI even for HSTS hosts. The user deserves a chance to override. Now that we've made the UI subtle, it's not like users are going to hit the button by accident. BUG=285376 R=thestig@chromium.org, tsepez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221355

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	chrome/renderer/chrome_render_view_observer.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cevans@chromium.org/23971005/1

7 years, 3 months ago (2013-09-05 01:53:22 UTC) #5

commit-bot: I haz the power

Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82958

7 years, 3 months ago (2013-09-05 03:04:45 UTC) #6

Chris Evans

7 years, 3 months ago (2013-09-05 06:47:49 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r221355 (presubmit successful).

Expand Messages | Collapse Messages