Issue 2397063002: [DevTools] Fixed breakpoints in hotreloaded scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2397063002: [DevTools] Fixed breakpoints in hotreloaded scripts (Closed)

Created:
4 years, 2 months ago by kozy

Modified:
4 years, 2 months ago

Reviewers:
lushnikov

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[DevTools] Fixed breakpoints in hotreloaded scripts We need to use last arrived script for ResourceScriptFile. Otherwise _isDiverged check will always return true in case of: eval("source1 //# sourceURL=foo.js") eval("source2 //# sourceURL=foo.js") BUG=617450, 623150 R=lushnikov@chromium.org Review-Url: https://codereview.chromium.org/2384953002 Cr-Commit-Position: refs/heads/master@{#422622} (cherry picked from commit c0d25adc44ebd36c2dc2565942a1884479c40004) Committed: https://chromium.googlesource.com/chromium/src/+/31c32c71acf292764248bb6716772ee9453c0fe5

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -2 lines)			Patch
A	third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice.html	View	1 chunk	+56 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/inspector/sources/dont-diverge-script-evaluated-twice-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

kozy

4 years, 2 months ago (2016-10-06 00:45:43 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
31c32c71acf292764248bb6716772ee9453c0fe5.