SkiaSampleRenderer - handle case where compiler won't cast jint to void*.

SkiaSampleRenderer - handle case where compiler won't cast jint to void*.

Committed: http://code.google.com/p/skia/source/detail?r=14244

[hal.canary, 2014-04-17 17:39:47]

PTAL

[scroggo, 2014-04-17 17:42:37]

On 2014/04/17 17:39:47, Hal Canary wrote:
> PTAL

lgtm

[djsollen, 2014-04-17 17:43:50]

lgtm with one suggestion

https://codereview.chromium.org/239703016/diff/1/platform_tools/android/app/j...
File platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp (right):

https://codereview.chromium.org/239703016/diff/1/platform_tools/android/app/j...
platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:257: jobject
thiz, jint owner, jfloat x, jfloat y, jint jstate)
I also think we should consider updating the owner variable to jlong to better
future proof this.

[hal.canary, 2014-04-17 17:58:15]

On 2014/04/17 17:43:50, djsollen wrote:
> lgtm with one suggestion
> 
>
https://codereview.chromium.org/239703016/diff/1/platform_tools/android/app/j...
> File platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp (right):
> 
>
https://codereview.chromium.org/239703016/diff/1/platform_tools/android/app/j...
> platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:257: jobject
> thiz, jint owner, jfloat x, jfloat y, jint jstate)
> I also think we should consider updating the owner variable to jlong to better
> future proof this.

But jlong cast to a void* won't work on a 32-bit system!

[djsollen, 2014-04-17 17:58:50]

On 2014/04/17 17:58:15, Hal Canary wrote:
> On 2014/04/17 17:43:50, djsollen wrote:
> > lgtm with one suggestion
> > 
> >
>
https://codereview.chromium.org/239703016/diff/1/platform_tools/android/app/j...
> > File platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp (right):
> > 
> >
>
https://codereview.chromium.org/239703016/diff/1/platform_tools/android/app/j...
> > platform_tools/android/app/jni/com_skia_SkiaSampleRenderer.cpp:257: jobject
> > thiz, jint owner, jfloat x, jfloat y, jint jstate)
> > I also think we should consider updating the owner variable to jlong to
better
> > future proof this.
> 
> But jlong cast to a void* won't work on a 32-bit system!

good point!

[hal.canary, 2014-04-17 19:40:32]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2014-04-17 19:40:53]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/halcanary@google.com/239703016/1

[commit-bot: I haz the power, 2014-04-17 19:41:13]

Change committed as 14244