Index: chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc |
diff --git a/chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc b/chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc |
index e0af3e12288b966c54160c030ca9ed0404455236..13b8f231d31b0fa06247bd88b863c4da31e93530 100644 |
--- a/chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc |
+++ b/chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc |
@@ -95,6 +95,9 @@ class WallpaperManagerBrowserTest : public InProcessBrowserTest, |
ash::test::DisplayManagerTestApi display_manager_test_api( |
ash::Shell::GetInstance()->display_manager()); |
display_manager_test_api.UpdateDisplay(display_specs); |
+ LOG(ERROR) << "UpdateDisplay(display_specs='" << display_specs |
+ << "') done."; |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
} |
void WaitAsyncWallpaperLoadStarted() { |
@@ -766,8 +769,7 @@ class TestObserver : public WallpaperManager::Observer { |
DISALLOW_COPY_AND_ASSIGN(TestObserver); |
}; |
-// Disabled due to flaky failures. crbug.com/362847 |
-IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DISABLED_DisplayChange) { |
+IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DisplayChange) { |
// TODO(derat|oshima|bshe): Host windows can't be resized on Win8. |
if (!ash::test::AshTestHelper::SupportsHostWindowResize()) |
return; |
@@ -784,18 +786,21 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DISABLED_DisplayChange) { |
// multiple displays are connected. |
UpdateDisplay("800x600"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset()); |
UpdateDisplay("800x600,800x600"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset()); |
UpdateDisplay("1366x800"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); |
@@ -803,18 +808,21 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DISABLED_DisplayChange) { |
// At larger sizes, large wallpapers should be used. |
UpdateDisplay("1367x800"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); |
UpdateDisplay("1367x801"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); |
UpdateDisplay("2560x1700"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); |
@@ -822,16 +830,19 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DISABLED_DisplayChange) { |
// Rotated smaller screen may use larger image. |
UpdateDisplay("800x600/r"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); |
UpdateDisplay("800x600/r,800x600"); |
WaitAsyncWallpaperLoadFinished(); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_SMALL, |
WallpaperManager::Get()->GetAppropriateResolution()); |
EXPECT_EQ(1, observer.GetUpdateWallpaperCountAndReset()); |
UpdateDisplay("1366x800/r"); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
WaitAsyncWallpaperLoadFinished(); |
EXPECT_EQ(WallpaperManager::WALLPAPER_RESOLUTION_LARGE, |
WallpaperManager::Get()->GetAppropriateResolution()); |
@@ -839,6 +850,7 @@ IN_PROC_BROWSER_TEST_P(WallpaperManagerBrowserTest, DISABLED_DisplayChange) { |
// Max display size didn't chagne. |
UpdateDisplay("900x800/r,400x1366"); |
+ WallpaperManager::GetAppropriateResolutionForTesting(); |
WaitAsyncWallpaperLoadFinished(); |
EXPECT_EQ(0, observer.GetUpdateWallpaperCountAndReset()); |
} |