Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 239703014: Add debug to WallpaperManagerBrowserTest.DisplayChange test. (Closed)

Created:
6 years, 8 months ago by Alexander Alekseev
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add debug to WallpaperManagerBrowserTest.DisplayChange test to diagnose failures. BUG=362847 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267040

Patch Set 1 #

Patch Set 2 : More debug. #

Patch Set 3 : Add debug to only WM test DisplayChange. #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M chrome/browser/chromeos/login/wallpaper_manager.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 1 2 3 6 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
Alexander Alekseev
oshima@, what do you think about adding additional debug to the test?
6 years, 8 months ago (2014-04-17 20:58:40 UTC) #1
oshima
On 2014/04/17 20:58:40, alemate wrote: > oshima@, what do you think about adding additional debug ...
6 years, 8 months ago (2014-04-21 20:33:14 UTC) #2
oshima
On 2014/04/21 20:33:14, oshima wrote: > On 2014/04/17 20:58:40, alemate wrote: > > oshima@, what ...
6 years, 7 months ago (2014-04-28 22:34:27 UTC) #3
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 7 months ago (2014-04-28 23:23:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/239703014/40001
6 years, 7 months ago (2014-04-28 23:26:09 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 23:30:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_clang_dbg tryserver.chromium on linux_chromium_clang_dbg tryserver.chromium on linux_chromium_gn_rel ...
6 years, 7 months ago (2014-04-28 23:30:17 UTC) #7
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 7 months ago (2014-04-29 00:02:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/239703014/60001
6 years, 7 months ago (2014-04-29 00:03:06 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 00:47:39 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 00:47:40 UTC) #11
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 7 months ago (2014-04-29 15:13:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/239703014/60001
6 years, 7 months ago (2014-04-29 15:13:34 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 22:01:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 22:01:09 UTC) #15
Alexander Alekseev
The CQ bit was checked by alemate@chromium.org
6 years, 7 months ago (2014-04-29 22:04:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alemate@chromium.org/239703014/60001
6 years, 7 months ago (2014-04-29 22:07:39 UTC) #17
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 02:00:25 UTC) #18
Message was sent while issue was closed. 
Change committed as 267040

Powered by Google App Engine
This is Rietveld 408576698