src/x64/builtins-x64.cc - Issue 239703012: X64: fix arguments adaptor stack check after r20751.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/builtins-x64.cc

Issue 239703012: X64: fix arguments adaptor stack check after r20751. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/builtins-x64.cc

diff --git a/src/x64/builtins-x64.cc b/src/x64/builtins-x64.cc

index 5803ad772318c98f1cfe3b5f15317e5312c4565c..19e7b533c9d425ed5062526818ae7f86e679db8d 100644

--- a/src/x64/builtins-x64.cc

+++ b/src/x64/builtins-x64.cc

@@ -1340,7 +1340,8 @@ static void ArgumentsAdaptorStackCheck(MacroAssembler* masm,

__ subp(rcx, rdx);

// Make rdx the space we need for the array when it is unrolled onto the

// stack.

- __ PositiveSmiTimesPowerOfTwoToInteger64(rdx, rax, kPointerSizeLog2);

+ __ movp(rdx, rbx);

+ __ shlp(rdx, Immediate(kPointerSizeLog2));

// Check if the arguments will overflow the stack.

__ cmpp(rcx, rdx);

__ j(less_equal, stack_overflow); // Signed comparison.

« no previous file with comments | « no previous file | no next file » | no next file with comments »