Issue 23970005: Add GN help for toolchain commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23970005: Add GN help for toolchain commands. (Closed)

Created:
7 years, 3 months ago by brettw

Modified:
7 years, 3 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add GN help for toolchain commands. BUG=288991 R=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223470

Patch Set 2 : review comments #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -5 lines)			Patch
	M	tools/gn/function_toolchain.cc	View	1	3 chunks	+87 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koz (OOO until 15th September)

lgtm https://codereview.chromium.org/23970005/diff/1/tools/gn/function_toolchain.cc File tools/gn/function_toolchain.cc (right): https://codereview.chromium.org/23970005/diff/1/tools/gn/function_toolchain.cc#newcode42 tools/gn/function_toolchain.cc:42: " A toolchain is a set of commands ...

7 years, 3 months ago (2013-09-16 23:05:42 UTC) #2

brettw

7 years, 3 months ago (2013-09-16 23:33:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r223470 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23970005: Add GN help for toolchain commands. (Closed)

Description

Patch Set 1 #

Patch Set 2 : review comments #

Messages