Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2396923003: [turbofan][x64] Use the root register for comparisons with certain roots. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan][x64] Use the root register for comparisons with certain roots. Emit code like this cmpq reg, [kRootRegister + offset] when selecting instructions for comparisons with immortal, immovable roots. This reduces register pressure as we don't need to load those roots into registers first. R=jarin@chromium.org TBR=hpayer@chromium.org Committed: https://crrev.com/e17ea8ddf2b1d4e45d8d010638684850460b2e47 Cr-Commit-Position: refs/heads/master@{#40022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M src/compiler/instruction-selector.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-06 06:50:41 UTC) #1
Benedikt Meurer
Hey Jaro, Hannes, This gives a small boost in some cases, and in general reduces ...
4 years, 2 months ago (2016-10-06 06:51:32 UTC) #4
Jarin
lgtm
4 years, 2 months ago (2016-10-06 07:14:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396923003/1
4 years, 2 months ago (2016-10-06 08:16:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 08:19:05 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 08:19:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e17ea8ddf2b1d4e45d8d010638684850460b2e47
Cr-Commit-Position: refs/heads/master@{#40022}

Powered by Google App Engine
This is Rietveld 408576698