Supervised Users always need custodian approval for permission increase

chrome/browser/extensions/extension_util.cc

Index: chrome/browser/extensions/extension_util.cc
diff --git a/chrome/browser/extensions/extension_util.cc b/chrome/browser/extensions/extension_util.cc
index 3260651a105adf19ac22c6bbf04f918c17c5fda9..df5aeb7b109a76f8b61375eddbb4767c58daf385 100644
--- a/chrome/browser/extensions/extension_util.cc
+++ b/chrome/browser/extensions/extension_util.cc
@@ -44,10 +44,6 @@ namespace extensions {
 namespace util {
 
 namespace {
-
-const char kSupervisedUserExtensionPermissionIncreaseFieldTrialName[] =
-    "SupervisedUserExtensionPermissionIncrease";
-
 // The entry into the prefs used to flag an extension as installed by custodian.
 // It is relevant only for supervised users.
 const char kWasInstalledByCustodianPrefName[] = "was_installed_by_custodian";
@@ -356,17 +352,5 @@ bool IsExtensionSupervised(const Extension* extension, Profile* profile) {
          profile->IsSupervised();
 }
 
-bool NeedCustodianApprovalForPermissionIncrease(const Profile* profile) {

[Marc Treib, 2016/10/06 09:23:16]

Ah, one more comment: Please remove this function also from the header!
(Can be in this CL or in a followup, whichever is easier)

[mamir, 2016/10/06 09:32:55]

Done!

-  if (!profile->IsSupervised())
-    return false;
-  // Query the trial group name first, to make sure it's properly initialized.
-  base::FieldTrialList::FindFullName(
-      kSupervisedUserExtensionPermissionIncreaseFieldTrialName);
-  std::string value = variations::GetVariationParamValue(
-      kSupervisedUserExtensionPermissionIncreaseFieldTrialName,
-      profile->IsChild() ? "child_account" : "legacy_supervised_user");
-  return value == "true";
-}
-
 }  // namespace util
 }  // namespace extensions