Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5127)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 2396903002: Supervised Users always need custodian approval for permission increase (Closed)
Patch Set: Response to code review Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index a0a25a2d7d54d2c20d05cf54f24e6a4929687178..ca28ba3ddfc16cb0b4f30268c2fa10ba0eb95e1f 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -1689,8 +1689,6 @@ void ExtensionService::CheckPermissionsIncrease(const Extension* extension,
// to a permissions increase, send a request to the custodian if the
// supervised user themselves can't re-enable the extension.
asargent_no_longer_on_chrome 2016/10/05 23:23:34 Should this comment be updated to reflect the fact
mamir 2016/10/06 09:09:23 Done.
if (extensions::util::IsExtensionSupervised(extension, profile_) &&
- extensions::util::NeedCustodianApprovalForPermissionIncrease(
- profile_) &&
!ExtensionSyncService::Get(profile_)->HasPendingReenable(
extension->id(), *extension->version())) {
SupervisedUserService* supervised_user_service =

Powered by Google App Engine
This is Rietveld 408576698