chrome/browser/extensions/extension_service.cc - Issue 2396903002: Supervised Users always need custodian approval for permission increase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 2396903002: Supervised Users always need custodian approval for permission increase (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index a0a25a2d7d54d2c20d05cf54f24e6a4929687178..ca28ba3ddfc16cb0b4f30268c2fa10ba0eb95e1f 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1689,8 +1689,6 @@ void ExtensionService::CheckPermissionsIncrease(const Extension* extension,

// to a permissions increase, send a request to the custodian if the

// supervised user themselves can't re-enable the extension.

if (extensions::util::IsExtensionSupervised(extension, profile_) &&

- extensions::util::NeedCustodianApprovalForPermissionIncrease(

- profile_) &&

!ExtensionSyncService::Get(profile_)->HasPendingReenable(

extension->id(), *extension->version())) {

SupervisedUserService* supervised_user_service =