chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc - Issue 2396893002: Enable the MD User Menu by default on trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

Issue 2396893002: Enable the MD User Menu by default on trunk. (Closed)

Patch Set: Address feedback on cocoa tests. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/sync_global_error_unittest.cc ('K') | « chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm ('k') | components/signin/core/common/signin_switches.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

diff --git a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

index c13186cf9a7583042dd5feae18269768f5b8fa57..6b190de37d70067b41a7fda837b839e6cf3deb39 100644

--- a/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

+++ b/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc

@@ -251,8 +251,12 @@ IN_PROC_BROWSER_TEST_F(ProfileChooserViewExtensionsTest, ViewProfileUMA) {

ASSERT_NO_FATAL_FAILURE(OpenProfileChooserView(browser()));

- histograms.ExpectUniqueSample("Profile.NewAvatarMenu.Upgrade",

- ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_VIEW, 1);

+ // The MD user menu doesn't display any upgrade toast so it doesn't log this

+ // in UMA.

+ if (!switches::IsMaterialDesignUserMenu()) {

+ histograms.ExpectUniqueSample("Profile.NewAvatarMenu.Upgrade",

+ ProfileMetrics::PROFILE_AVATAR_MENU_UPGRADE_VIEW, 1);

+ }

}

IN_PROC_BROWSER_TEST_F(ProfileChooserViewExtensionsTest, LockProfile) {