third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js - Issue 2396883005: DevTools: add test for for page reload with screenshots not stopping recording

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2396883005: DevTools: add test for for page reload with screenshots not stopping recording (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/network-recording-after-reload-with-screenshots-enabled.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

index 3176e423eef3cf19c4842948d254357c66bc581a..0961e6d5b7d32596f57ea190eba58f5130c9355f 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

@@ -105,6 +105,8 @@ WebInspector.NetworkPanel = function()

WebInspector.DataSaverInfobar.maybeShowInPanel(this);

}

+WebInspector.NetworkPanel.displayScreenshotDelay = 1000;

WebInspector.NetworkPanel.prototype = {

/**

* @param {!WebInspector.Event} event

@@ -273,7 +275,7 @@ WebInspector.NetworkPanel.prototype = {

_load: function(event)

{

if (this._filmStripRecorder && this._filmStripRecorder.isRecording())

- this._pendingStopTimer = setTimeout(this._stopFilmStripRecording.bind(this), 1000);

+ this._pendingStopTimer = setTimeout(this._stopFilmStripRecording.bind(this), WebInspector.NetworkPanel.displayScreenshotDelay);

_stopFilmStripRecording: function()