MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325
Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Committed: https://crrev.com/578c39e0edd49f49d0e368eccec170c6715c3808
Cr-Original-Commit-Position: refs/heads/master@{#423450}
Cr-Commit-Position: refs/heads/master@{#423782}

[karandeepb, 2016-10-06 05:35:36]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-10-06 05:43:36]

Description was changed from

==========
Fix DCHECK crash.
==========

to

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to 
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325
==========

[karandeepb, 2016-10-06 05:45:39]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2016-10-06 05:45:40]

PTAL Trent.

[tapted, 2016-10-06 05:48:57]

lgtm

[karandeepb, 2016-10-06 05:49:19]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-10-06 05:49:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 06:23:46]

Description was changed from

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to 
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325
==========

to

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to 
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325
==========

[commit-bot: I haz the power, 2016-10-06 06:23:47]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-10-06 06:26:11]

Description was changed from

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to 
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325
==========

to

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}
==========

[commit-bot: I haz the power, 2016-10-06 06:26:12]

Patchset 1 (id:??) landed as
https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}

[karandeepb, 2016-10-06 06:38:02]

A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2399783002/ by karandeepb@chromium.org.

The reason for reverting is: Breaks compile. Probably because the
CountBridgedWindows function is only compiled in when DCHECK are ON..

[tapted, 2016-10-06 07:38:46]

https://codereview.chromium.org/2396883004/diff/20001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_native_widget.mm (right):

https://codereview.chromium.org/2396883004/diff/20001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_native_widget.mm:315: #if DCHECK_IS_ON()
dang it - typically this is required to avoid a "this is unused" warning (which
also only shows up once you get run on a bot that doesn't have DCHECKs :/). But
I guess we can just try without. So, lgtm with this #if removed as well :) (but
perhaps worth just building a is_debug = false build without DCHECKs to ensure
that's the case)

[karandeepb, 2016-10-07 01:03:57]

https://codereview.chromium.org/2396883004/diff/20001/ui/views/cocoa/bridged_...
File ui/views/cocoa/bridged_native_widget.mm (right):

https://codereview.chromium.org/2396883004/diff/20001/ui/views/cocoa/bridged_...
ui/views/cocoa/bridged_native_widget.mm:315: #if DCHECK_IS_ON()
On 2016/10/06 07:38:46, tapted wrote:
> dang it - typically this is required to avoid a "this is unused" warning
(which
> also only shows up once you get run on a bot that doesn't have DCHECKs :/).
But
> I guess we can just try without. So, lgtm with this #if removed as well :)
(but
> perhaps worth just building a is_debug = false build without DCHECKs to ensure
> that's the case)

Yeah, so the arguments to the DCHECK macros are still compiled in, but not used
on RELEASE builds, which caused the failure.

[karandeepb, 2016-10-07 01:04:50]

Description was changed from

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}
==========

to

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}
==========

[karandeepb, 2016-10-07 01:08:13]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2016-10-07 01:08:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2396883004/#ps40001
(title: "Fix compile on Release bots.")

[commit-bot: I haz the power, 2016-10-07 01:08:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2016-10-07 01:22:26]

The CQ bit was unchecked by karandeepb@chromium.org

[karandeepb, 2016-10-07 02:20:01]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-10-07 02:20:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 02:25:20]

Description was changed from

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}
==========

to

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}
==========

[commit-bot: I haz the power, 2016-10-07 02:25:21]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-07 02:28:18]

Description was changed from

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Cr-Commit-Position: refs/heads/master@{#423450}
==========

to

==========
MacViews: Fix crash due to failed DCHECK in BridgedNativeWidget.

BridgedNativeWidget::NotifyVisibilityChangeDown() currently has DCHECKs to
ensure that
- When a window is hidden, all its child windows are hidden and removed from its
  child window list.
- When a window is made visible, all its child windows which want to become
  visible are made visible and added to its child window list.

However, this does not account for windows which may be added by AppKit, for
example, the Mac Dictionary popup. This CL modifies the DCHECKs to correctly
account for windows added by AppKit.

BUG=653325

Committed: https://crrev.com/93d211ca178ee90dc77d3825cdd1c7fd3ce5f021
Committed: https://crrev.com/578c39e0edd49f49d0e368eccec170c6715c3808
Cr-Original-Commit-Position: refs/heads/master@{#423450}
Cr-Commit-Position: refs/heads/master@{#423782}
==========

[commit-bot: I haz the power, 2016-10-07 02:28:19]

Patchset 2 (id:??) landed as
https://crrev.com/578c39e0edd49f49d0e368eccec170c6715c3808
Cr-Commit-Position: refs/heads/master@{#423782}