Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: components/exo/wm_helper.h

Issue 2396883003: exo: Fix dragging edge cases (Closed)
Patch Set: Fix presubmit errors Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/exo/wm_helper.h
diff --git a/components/exo/wm_helper.h b/components/exo/wm_helper.h
index 306c1f11c565eea0ba3467df2e9bd63c91b0e5ed..c08e66ecaee40fddde0bc018a0e1ff31d991fa38 100644
--- a/components/exo/wm_helper.h
+++ b/components/exo/wm_helper.h
@@ -53,13 +53,16 @@ class WMHelper {
virtual ~CursorObserver() {}
};
- class MaximizeModeObserver {
+ class ShellObserver {
public:
- virtual void OnMaximizeModeStarted() = 0;
- virtual void OnMaximizeModeEnded() = 0;
+ virtual void OnMaximizeModeStarted() {}
+ virtual void OnMaximizeModeEnded() {}
+
+ virtual void OnOverviewModeStarted() {}
+ virtual void OnOverviewModeEnded() {}
protected:
- virtual ~MaximizeModeObserver() {}
+ virtual ~ShellObserver() {}
};
class AccessibilityObserver {
@@ -81,8 +84,8 @@ class WMHelper {
void RemoveFocusObserver(FocusObserver* observer);
void AddCursorObserver(CursorObserver* observer);
void RemoveCursorObserver(CursorObserver* observer);
- void AddMaximizeModeObserver(MaximizeModeObserver* observer);
- void RemoveMaximizeModeObserver(MaximizeModeObserver* observer);
+ void AddShellObserver(ShellObserver* observer);
+ void RemoveShellObserver(ShellObserver* observer);
void AddAccessibilityObserver(AccessibilityObserver* observer);
void RemoveAccessibilityObserver(AccessibilityObserver* observer);
@@ -112,13 +115,15 @@ class WMHelper {
void NotifyCursorSetChanged(ui::CursorSetType cursor_set);
void NotifyMaximizeModeStarted();
void NotifyMaximizeModeEnded();
+ void NotifyOverviewModeStarted();
+ void NotifyOverviewModeEnded();
void NotifyAccessibilityModeChanged();
private:
base::ObserverList<ActivationObserver> activation_observers_;
base::ObserverList<FocusObserver> focus_observers_;
base::ObserverList<CursorObserver> cursor_observers_;
- base::ObserverList<MaximizeModeObserver> maximize_mode_observers_;
+ base::ObserverList<ShellObserver> shell_observers_;
base::ObserverList<AccessibilityObserver> accessibility_observers_;
DISALLOW_COPY_AND_ASSIGN(WMHelper);

Powered by Google App Engine
This is Rietveld 408576698