[sensors] Fix crash after 85cc22d when using async creation of sensors.

[sensors] Fix crash after 85cc22d when using async creation of sensors.

The fix is simple as the callback was called with null pointers. Make
sure to call it with the right arguments.

BUG=606766
Committed: https://crrev.com/24e8468bd738a1df17fe4f20ea251b3d87c4978a
Cr-Commit-Position: refs/heads/master@{#423259}

[darktears, 2016-10-05 17:20:28]

alexis.menard@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com, timvolodine@chromium.org

[darktears, 2016-10-05 17:20:34]

The CQ bit was checked by alexis.menard@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 17:20:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[darktears, 2016-10-05 17:21:08]

On 2016/10/05 17:20:28, darktears wrote:

@timvolodine, misha : PTAL, should be quick to review.

@maksim : FYI

[Mikhail, 2016-10-05 17:22:29]

lgtm

[timvolodine, 2016-10-05 17:59:36]

lgtm % question, if there is a more specific 'crash' crbug pls add to
description.

https://codereview.chromium.org/2396873002/diff/1/device/generic_sensor/senso...
File device/generic_sensor/sensor_provider_impl.cc (right):

https://codereview.chromium.org/2396873002/diff/1/device/generic_sensor/senso...
device/generic_sensor/sensor_provider_impl.cc:99:
NotifySensorCreated(std::move(init_params), sensor_impl.get(), callback);
is the order of Notify and MakeStrongBinding important here?

[darktears, 2016-10-05 18:05:38]

On 2016/10/05 17:59:36, timvolodine wrote:
> lgtm % question, if there is a more specific 'crash' crbug pls add to
> description.

None, I found that while working on my other CL.

> 
>
https://codereview.chromium.org/2396873002/diff/1/device/generic_sensor/senso...
> File device/generic_sensor/sensor_provider_impl.cc (right):
> 
>
https://codereview.chromium.org/2396873002/diff/1/device/generic_sensor/senso...
> device/generic_sensor/sensor_provider_impl.cc:99:
> NotifySensorCreated(std::move(init_params), sensor_impl.get(), callback);
> is the order of Notify and MakeStrongBinding important here?

Yes. mojo::MakeStrongBinding(std::move(sensor_impl)...) . We need to use the
sensor_impl pointer before we call MakeStrongBinding with std::move.

[commit-bot: I haz the power, 2016-10-05 19:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:09:58]

Dry run: This issue passed the CQ dry run.

[darktears, 2016-10-05 19:39:57]

The CQ bit was checked by alexis.menard@intel.com

[commit-bot: I haz the power, 2016-10-05 19:40:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 19:49:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 19:51:07]

Description was changed from

==========
[sensors] Fix crash after 85cc22d when using async creation of sensors.

The fix is simple as the callback was called with null pointers. Make
sure to call it with the right arguments.

BUG=606766
==========

to

==========
[sensors] Fix crash after 85cc22d when using async creation of sensors.

The fix is simple as the callback was called with null pointers. Make
sure to call it with the right arguments.

BUG=606766

Committed: https://crrev.com/24e8468bd738a1df17fe4f20ea251b3d87c4978a
Cr-Commit-Position: refs/heads/master@{#423259}
==========

[commit-bot: I haz the power, 2016-10-05 19:51:08]

Patchset 1 (id:??) landed as
https://crrev.com/24e8468bd738a1df17fe4f20ea251b3d87c4978a
Cr-Commit-Position: refs/heads/master@{#423259}