Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: ash/public/interfaces/system_tray.mojom

Issue 2396863004: chromeos: Refactor system tray ShowNetworkSettingsForGuid for mash (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/public/interfaces/system_tray.mojom
diff --git a/ash/public/interfaces/system_tray.mojom b/ash/public/interfaces/system_tray.mojom
index 68caeb65b7c2db5c7fbc767d751a8cb77c3d2ced..3cdb3e1be62fa1c0bef936d903d4ced558ce454d 100644
--- a/ash/public/interfaces/system_tray.mojom
+++ b/ash/public/interfaces/system_tray.mojom
@@ -22,8 +22,6 @@ interface SystemTrayClient {
// TODO(crbug.com/647412): ShowSetTimeDialog();
- // TODO(crbug.com/647412): ShowNetworkSettingsForGuid(string guid);
-
// Shows settings related to multiple displays.
ShowDisplaySettings();
@@ -56,6 +54,12 @@ interface SystemTrayClient {
// TODO(crbug.com/647412): ShowEnterpriseInfo();
+ // Shows settings related to networking. If |network_id| is empty, shows
+ // general settings. Otherwise shows settings for the individual network.
+ // On devices |network_id| is a GUID, but on Linux desktop and in tests it can
+ // be any string.
+ ShowNetworkSettings(string network_id);
stevenjb 2016/10/13 22:03:09 const string& ?
James Cook 2016/10/13 22:16:07 mojom files use "string", which is translated to "
stevenjb 2016/10/13 23:04:37 AH, doh, I didn't notice this was a .mojom file.
+
// Shows UI for changing proxy settings.
ShowProxySettings();
};
« no previous file with comments | « ash/common/system/tray/system_tray_delegate.cc ('k') | chrome/browser/ui/ash/network_connect_delegate_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698