Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: ash/common/system/chromeos/network/network_state_list_detailed_view.cc

Issue 2396863004: chromeos: Refactor system tray ShowNetworkSettingsForGuid for mash (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/network/network_state_list_detailed_view.cc
diff --git a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
index ef7294ea66d60eafbc2e490a2255d339a07ce3c7..57d600a493370f4c14dc5ea0e0f866fa7cc7aa37 100644
--- a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
+++ b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
@@ -435,7 +435,7 @@ void NetworkStateListDetailedView::HandleViewClicked(views::View* view) {
list_type_ == LIST_TYPE_VPN
? UMA_STATUS_AREA_SHOW_NETWORK_CONNECTION_DETAILS
: UMA_STATUS_AREA_SHOW_VPN_CONNECTION_DETAILS);
- WmShell::Get()->system_tray_delegate()->ShowNetworkSettingsForGuid(
+ WmShell::Get()->system_tray_controller()->ShowNetworkSettings(
network ? network->guid() : "");
msw 2016/10/05 22:56:36 nit: s/""/std::string()/
James Cook 2016/10/05 23:03:52 Done.
} else {
WmShell::Get()->RecordUserMetricsAction(
@@ -513,7 +513,7 @@ void NetworkStateListDetailedView::ShowSettings() {
WmShell::Get()->RecordUserMetricsAction(
list_type_ == LIST_TYPE_VPN ? UMA_STATUS_AREA_VPN_SETTINGS_OPENED
: UMA_STATUS_AREA_NETWORK_SETTINGS_OPENED);
- WmShell::Get()->system_tray_delegate()->ShowNetworkSettingsForGuid("");
+ WmShell::Get()->system_tray_controller()->ShowNetworkSettings("");
msw 2016/10/05 22:56:36 nit: s/""/std::string()/
James Cook 2016/10/05 23:03:52 Done.
}
void NetworkStateListDetailedView::CreateNetworkExtra() {
« no previous file with comments | « no previous file | ash/common/system/tray/system_tray_controller.h » ('j') | chrome/browser/ui/ash/system_tray_client.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698