Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2396803003: Make mojom.srcjar files produce hermetic zip files. (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, chromium-reviews, darin (slow to review), Dirk Pranke, qsr+mojo_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make mojom.srcjar files produce hermetic zip files. This makes compiles faster because they can now detect when inputs haven't changed. BUG=523420 Committed: https://crrev.com/1b06cd3f4afbc00ec83ffd199e78b5b34c804b98 Cr-Commit-Position: refs/heads/master@{#423422}

Patch Set 1 #

Patch Set 2 : fix accidentally deleted file! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 4 chunks +7 lines, -10 lines 0 comments Download
D mojo/public/tools/gn/zip.py View 1 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
agrieve
🐻
4 years, 2 months ago (2016-10-06 01:17:26 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-06 01:27:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396803003/1
4 years, 2 months ago (2016-10-06 01:29:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/43534) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 2 months ago (2016-10-06 01:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396803003/20001
4 years, 2 months ago (2016-10-06 01:59:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 03:48:00 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 03:50:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1b06cd3f4afbc00ec83ffd199e78b5b34c804b98
Cr-Commit-Position: refs/heads/master@{#423422}

Powered by Google App Engine
This is Rietveld 408576698