[Android WebView] Add functionality to enable features and enable the spellcheck feature.

[Android WebView] Add functionality to enable features and enable the spellcheck feature.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609
Committed: https://crrev.com/a1d692bf7489e628a2d6dc6786495e32c0059250
Cr-Commit-Position: refs/heads/master@{#423513}

[timvolodine, 2016-10-05 12:53:30]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 12:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-10-05 13:44:30]

Description was changed from

==========
[Android WebView] Add functionality to enable spellchecking feature and enable
it.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609
==========

to

==========
[Android WebView] Add functionality to enable features and enable the spellcheck
feature.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609
==========

[timvolodine, 2016-10-05 13:45:36]

timvolodine@chromium.org changed reviewers:
+ tobiasjs@chromium.org, torne@chromium.org

[Tobias Sargeant, 2016-10-05 13:56:15]

LGTM, with comment below.

https://codereview.chromium.org/2396803002/diff/1/android_webview/browser/com...
File android_webview/browser/command_line_helper.cc (right):

https://codereview.chromium.org/2396803002/diff/1/android_webview/browser/com...
android_webview/browser/command_line_helper.cc:20: bool contains(const
vector<string>& features, const string& feature_name) {
This is base::ContainsValue in base/stl_util.h

[commit-bot: I haz the power, 2016-10-05 14:11:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 14:11:30]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[timvolodine, 2016-10-06 11:56:27]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 11:56:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[timvolodine, 2016-10-06 11:58:43]

https://codereview.chromium.org/2396803002/diff/1/android_webview/browser/com...
File android_webview/browser/command_line_helper.cc (right):

https://codereview.chromium.org/2396803002/diff/1/android_webview/browser/com...
android_webview/browser/command_line_helper.cc:20: bool contains(const
vector<string>& features, const string& feature_name) {
On 2016/10/05 13:56:15, Tobias Sargeant wrote:
> This is base::ContainsValue in base/stl_util.h

yes thanks, I thought there should be something in base for this.. Done

[commit-bot: I haz the power, 2016-10-06 12:41:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 12:41:52]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[timvolodine, 2016-10-06 12:59:42]

The CQ bit was checked by timvolodine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 12:59:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 13:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 13:51:53]

Dry run: This issue passed the CQ dry run.

[timvolodine, 2016-10-06 13:53:40]

The CQ bit was checked by timvolodine@chromium.org

[timvolodine, 2016-10-06 13:53:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
tobiasjs@chromium.org
Link to the patchset: https://codereview.chromium.org/2396803002/#ps40001
(title: "fix compile")

[commit-bot: I haz the power, 2016-10-06 13:54:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 13:59:28]

Description was changed from

==========
[Android WebView] Add functionality to enable features and enable the spellcheck
feature.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609
==========

to

==========
[Android WebView] Add functionality to enable features and enable the spellcheck
feature.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609
==========

[commit-bot: I haz the power, 2016-10-06 13:59:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 14:00:52]

Description was changed from

==========
[Android WebView] Add functionality to enable features and enable the spellcheck
feature.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609
==========

to

==========
[Android WebView] Add functionality to enable features and enable the spellcheck
feature.

This patch adds the necessary generic methods to selectively enable a
feature in webview. The feature is only added if it is not yet enabled
(using --enable-features switch) and not disabled (using
--disable-features).

This patch also enables spellchecking in WebView by default, but only
on non low-end devices.

The feature can be disabled via the command line:
echo 'chrome --disable-features=AndroidSpellCheckerNonLowEnd' > \
/data/local/tmp/webview-command-line

BUG=583616, 629609

Committed: https://crrev.com/a1d692bf7489e628a2d6dc6786495e32c0059250
Cr-Commit-Position: refs/heads/master@{#423513}
==========

[commit-bot: I haz the power, 2016-10-06 14:00:53]

Patchset 3 (id:??) landed as
https://crrev.com/a1d692bf7489e628a2d6dc6786495e32c0059250
Cr-Commit-Position: refs/heads/master@{#423513}