rebaseline.py: add bug-filing URL to error message

rebaseline.py: add bug-filing URL to error message

R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=11133

[epoger, 2013-09-04 20:05:56]

https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py
File tools/rebaseline.py (right):

https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py#newcode124
tools/rebaseline.py:124: '\nHalting at first exception.\n' +
Here's the before-and-after error message.  Any further adjustments to suggest?

BEFORE:

$ tools/rebaseline.py --actuals-base-url BADURL
Halting at first exception; to keep going, re-run with the
--keep-going-on-failure option set.
Traceback (most recent call last):
  File "tools/rebaseline.py", line 418, in <module>
    exception_handler.RaiseExceptionOrContinue()
  File "tools/rebaseline.py", line 416, in <module>
    rebaseliner.RebaselineSubdir(builder=builder)
  File "tools/rebaseline.py", line 264, in RebaselineSubdir
    sections=sections)
  File "tools/rebaseline.py", line 228, in _GetActualResults
    json_contents = self._GetFileContents(json_url)
  File "tools/rebaseline.py", line 204, in _GetFileContents
    return open(filepath, 'r').read()
IOError: [Errno 2] No such file or directory:
'BADURL/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/actual-results.json'


AFTER:

$ tools/rebaseline.py --actuals-base-url BADURL

Halting at first exception.
Please file a bug, containing the following stack trace, at
https://code.google.com/p/skia/issues/entry .

Afterwards, you can re-run with the --keep-going-on-failure option set.

Traceback (most recent call last):
  File "tools/rebaseline.py", line 421, in <module>
    exception_handler.RaiseExceptionOrContinue()
  File "tools/rebaseline.py", line 419, in <module>
    rebaseliner.RebaselineSubdir(builder=builder)
  File "tools/rebaseline.py", line 267, in RebaselineSubdir
    sections=sections)
  File "tools/rebaseline.py", line 231, in _GetActualResults
    json_contents = self._GetFileContents(json_url)
  File "tools/rebaseline.py", line 207, in _GetFileContents
    return open(filepath, 'r').read()
IOError: [Errno 2] No such file or directory:
'BADURL/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/actual-results.json'

https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py#newcode370
tools/rebaseline.py:370: parser.add_argument('--keep-going-on-failure',
action='store_true',
For now, I'm going to keep the default as "halt immediately", because I think
most of the failures have been resolved now that we have expectations committed
for all platforms.

As we discussed... if we are still seeing errors much of the time, I will change
the default setting, at least temporarily.

[epoger, 2013-09-04 20:08:48]

https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py
File tools/rebaseline.py (right):

https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py#newcode124
tools/rebaseline.py:124: '\nHalting at first exception.\n' +
Updated the message in patchset 2.

[bsalomon, 2013-09-05 13:17:42]

On 2013/09/04 20:08:48, epoger wrote:
> https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py
> File tools/rebaseline.py (right):
> 
> https://codereview.chromium.org/23968002/diff/1/tools/rebaseline.py#newcode124
> tools/rebaseline.py:124: '\nHalting at first exception.\n' +
> Updated the message in patchset 2.

lgtm

[epoger, 2013-09-06 17:26:13]

Committed patchset #2 manually as r11133 (presubmit successful).