Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: components/translate/core/browser/BUILD.gn

Issue 2396783002: Add LanguageModel, a keyed service that collects language info from CLD. (Closed)
Patch Set: Bernhard's comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/BUILD.gn
diff --git a/components/translate/core/browser/BUILD.gn b/components/translate/core/browser/BUILD.gn
index 5599ed5a94a9c8615bbd4ddb3c99bf7234abe985..05fd0fa3e45411ef21390e00bc0f970f47bfd09d 100644
--- a/components/translate/core/browser/BUILD.gn
+++ b/components/translate/core/browser/BUILD.gn
@@ -6,6 +6,8 @@ import("//build/config/ui.gni")
static_library("browser") {
sources = [
+ "language_model.cc",
+ "language_model.h",
"language_state.cc",
"language_state.h",
"page_translated_details.h",
@@ -47,6 +49,7 @@ static_library("browser") {
"//base",
"//base:i18n",
"//components/data_use_measurement/core",
+ "//components/keyed_service/core",
"//components/language_usage_metrics",
"//components/metrics",
"//components/pref_registry",
@@ -55,6 +58,7 @@ static_library("browser") {
"//components/strings",
"//components/translate/core/browser/proto",
"//components/translate/core/common",
+ "//components/translate/core/language_detection",
droger 2016/10/05 15:39:59 Do you really need this? If so, we should at leas
jkrcal 2016/10/06 08:50:58 Right, probably not needed. Let me test it on the
"//components/variations",
"//google_apis",
"//net",
@@ -82,6 +86,7 @@ static_library("browser") {
source_set("unit_tests") {
testonly = true
sources = [
+ "language_model_unittest.cc",
"language_state_unittest.cc",
"mock_translate_driver.cc",
"mock_translate_driver.h",
@@ -99,6 +104,7 @@ source_set("unit_tests") {
"//components/infobars/core",
"//components/pref_registry:test_support",
"//components/prefs",
+ "//components/prefs:test_support",
"//components/translate/core/browser/proto",
"//components/translate/core/common",
"//components/variations",

Powered by Google App Engine
This is Rietveld 408576698