components/translate/content/browser/language_model_observer.cc - Issue 2396783002: Add LanguageModel, a keyed service that collects language info from CLD.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/translate/content/browser/language_model_observer.cc

Issue 2396783002: Add LanguageModel, a keyed service that collects language info from CLD. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/translate/content/browser/language_model_observer.h"

	6

	7 #include "components/translate/core/browser/language_model.h"

	8 #include "components/translate/core/common/language_detection_details.h"

	9

	10 namespace translate {

	11

	12 LanguageModelObserver::LanguageModelObserver(

	13 translate::LanguageModel* language_model)

	14 : language_model_(language_model) {}

	15

	16 LanguageModelObserver::~LanguageModelObserver() {}

	17

	18 void LanguageModelObserver::OnLanguageDetermined(

	19 const translate::LanguageDetectionDetails& details) {

	20 // Inform the language model about the language detected by CLD.

	21 if (details.is_cld_reliable)

	22 language_model_->OnPageVisited(details.cld_language);
	droger 2016/10/05 13:37:26 Actually you can probably simplify here: get rid o Actually you can probably simplify here: get rid of this class entirely and move these two lines of code to ChromeTranslateClient::OnLanguageDetermined. jkrcal 2016/10/05 15:14:46 Done. Show quoted text On 2016/10/05 13:37:26, droger wrote: > Actually you can probably simplify here: > get rid of this class entirely and move these two lines of code to > ChromeTranslateClient::OnLanguageDetermined. Done.
	23 }

	24

	25 } // namespace translate

OLD	NEW