chrome/browser/metrics/metrics_memory_details.h - Issue 2396743002: Leak reports collect information about the memory usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_memory_details.h

Issue 2396743002: Leak reports collect information about the memory usage (Closed)

Patch Set: Fixed order of initialization Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_memory_details.h

diff --git a/chrome/browser/metrics/metrics_memory_details.h b/chrome/browser/metrics/metrics_memory_details.h

index 23badc568a1f8d6f14330561a6ec994221f7503a..483bb81e1d52d9f71eba5f819ece9d2928015e7c 100644

--- a/chrome/browser/metrics/metrics_memory_details.h

+++ b/chrome/browser/metrics/metrics_memory_details.h

@@ -27,7 +27,7 @@ class MemoryGrowthTracker {

// If no memory usage of |pid| has not been recorded so far or 30 minutes

// have not passed since last record, it just returns false.

// |sample| is memory usage in kB.

- bool UpdateSample(base::ProcessId pid, int sample, int* diff);

+ virtual bool UpdateSample(base::ProcessId pid, int sample, int* diff);

private:

// Latest metrics about record time and memory usage at that time per process.