Leak reports collect information about the memory usage

chrome/browser/metrics/leak_detector/leak_detector_controller.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_
 #define CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_
 
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/macros.h"
 #include "base/threading/thread_checker.h"
 #include "chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h"
+#include "chrome/browser/metrics/metrics_memory_details.h"
 #include "components/metrics/leak_detector/leak_detector.h"
 #include "components/metrics/proto/memory_leak_report.pb.h"
 
 namespace metrics {
 
 // This class initializes the LeakDetector on the browser process and registers
 // itself to be notified of leak reports.
 class LeakDetectorController
     : public LeakDetector::Observer,
       public LeakDetectorRemoteController::LocalController {
  public:
   LeakDetectorController();
   ~LeakDetectorController() override;
 
   // Retrieves all reports in |stored_reports_|, moving them to |*reports|.
   // |stored_reports_| is empty afterwards.
   void GetLeakReports(std::vector<MemoryLeakReportProto>* reports);
 
  protected:
   // LeakDetector::Observer:
   void OnLeaksFound(const std::vector<MemoryLeakReportProto>& reports) override;
 
   // LeakDetectorRemoteController::LocalController:
   MemoryLeakReportProto::Params GetParamsAndRecordRequest() override;
   void SendLeakReports(
       const std::vector<MemoryLeakReportProto>& reports) override;
   void OnRemoteProcessShutdown() override;
 
+  void set_enable_collect_memory_usage_(bool enabled) {

[Simon Que, 2016/10/07 20:24:25]

Nit: No trailing underscore in mutator name.

[mwlodar, 2016/10/07 21:23:42]

Done.

+    enable_collect_memory_usage_ = enabled;
+  }
+
  private:
+  // Accumulates total memory usage info inside MetricsMemoryDetails.
+  class TotalMemoryGrowthTracker : public MemoryGrowthTracker {
+   public:
+    TotalMemoryGrowthTracker();
+    ~TotalMemoryGrowthTracker();
+
+    // Updates the inner counter by sample (in kb). Returns always false
+    // to suppress generating growth/shrink histograms in MetricsMemoryDetails.
+    bool UpdateSample(base::ProcessId pid, int sample, int* diff) override;
+
+    size_t total_usage_kb() const { return total_usage_kb_; }
+    void reset() { total_usage_kb_ = 0; }
+
+   private:
+    size_t total_usage_kb_;
+  };
+
   // Returns true to indicate that LeakDetector should be enabled on a renderer
   // process. This is determined as follows:
   // 1. If the number of processes running LeakDetector is not at max, returns
   //    true with a probability of |per_process_enable_probability_|.
   // 2. If the number of processes running LeakDetector has reached the max,
   //    returns false.
   bool ShouldRandomlyEnableLeakDetectorOnRendererProcess() const;
 
   // Stores a given array of leak reports in |stored_reports_|. |process_type|
   // is the type of process that generated these reports. The reports must all
   // come from the same process type.
   void StoreLeakReports(const std::vector<MemoryLeakReportProto>& reports,
                         MemoryLeakReportProto::ProcessType process_type);
 
+  // Method called from MetricsMemoryDetails when memory usage gets measured.
+  // Updates |memory_usage_info| in stored_reports_[i] for i >= |index|.
+  void OnMemoryDetailCollectionDone(size_t index);
+
   // All leak reports received through OnLeakFound() are stored in protobuf
   // format.
   std::vector<MemoryLeakReportProto> stored_reports_;
 
   // Contains all the parameters passed to LeakDetector. Store them in a single
   // protobuf message instead of in separate member variables.
   const MemoryLeakReportProto::Params params_;
 
   // The build ID of the current Chrome binary.
   std::vector<uint8_t> build_id_;
@@ skipping 10 matching lines @@
   // simultaneously.
   int max_renderer_processes_with_leak_detector_enabled_;
 
   // The number of renderer processes on which the leak detector has been
   // enabled and is running.
   int num_renderer_processes_with_leak_detector_enabled_;
 
   // For thread safety.
   base::ThreadChecker thread_checker_;
 
+  // An object passed to MetricsMemoryDetails for collecting memory usage.
+  TotalMemoryGrowthTracker total_memory_growth_tracker_;
+
+  // A flag indicating if a task should be scheduled to populate memory usage
+  // information in the reports.
+  bool enable_collect_memory_usage_;

[Simon Que, 2016/10/07 20:24:25]

Nit: incorrect grammar, try: enable_memory_usage_collection_

[mwlodar, 2016/10/07 21:23:42]

Done.

+
+  // Indicates that collecting memory usage is running.
+  bool waiting_for_collect_memory_usage_;
+
+  // For passing |this| into a callback.
+  base::WeakPtrFactory<LeakDetectorController> weak_ptr_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(LeakDetectorController);
 };
 
 }  // namespace metrics
 
 #endif  // CHROME_BROWSER_METRICS_LEAK_DETECTOR_LEAK_DETECTOR_CONTROLLER_H_