Use multi-profile mount point by default after browser crash and in Guest session.

Use multi-profile mount point by default after browser crash and in Guest session.

Add support for legacy values for --login-profile switch: user / stub-user. These will be added to user data dir as is (i.e. /home/chronos/user) unless --multi-profiles switch is added.

All other values passed to --login-profile will be treated as multi-profiles mount point and "u-" prefix will be added to them (i.e. /home/chronos/u-user_id_hash_string).

Supported configurations after this change:
* --login-profile=user, no --multi-profiles switch
Default configuration, used after session is started from login screen
/home/chronos/user profile dir is used

* --login-profile=[hash], no --multi-profiles switch
* --login-profile=hash --multi-profiles
Passed after browser crash inside session + on relaunching Chrome in Guest session. Chrome will add "u-" prefix.
/home/chronos/u-hash profile dir is used

* --login-profile=user --multi-profiles
Session is started from sign in screen
login-profile switch is ignored, /home/chronos/u-hash profile dir is used

Depends on session_manager change which will be committed after this change:
https://chromium-review.googlesource.com/#/c/169850/

BUG=294184
TEST=manually, w&w/o --multi-profiles: guest session, browser crash inside session
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224130

[Dmitry Polukhin, 2013-09-18 15:46:06]

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/profiles/profile_helper.h (right):

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/profiles/profile_helper.h:67: base::FilePath
GetUserProfileDir(const std::string& user_id_hash);
I made similar function UserManager::GetUserProfileDir, I think we need to use
it and remove Chrome OS specific code from Profiles.

[Nikita (slow), 2013-09-18 16:22:55]

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/profiles/profile_helper.h (right):

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/profiles/profile_helper.h:67: base::FilePath
GetUserProfileDir(const std::string& user_id_hash);
On 2013/09/18 15:46:06, Dmitry Polukhin wrote:
> I made similar function UserManager::GetUserProfileDir, 

I don't see this function in user_manager.h / user_manager_impl.h
 
> I think we need to use
> it and remove Chrome OS specific code from Profiles.

You mean ProfileManager? Yes, it needs to be cleaned up but looking at
profile_manager.cc I see that UserManager is used only once:

if (chromeos::UserManager::Get()->IsLoggedInAsGuest())

While ProfileHelper was decided to be a way to capture Chrome OS specific code
paths that need to be executed in ProfileManager. So I would prefer to keep to
that approach.

[Dmitry Polukhin, 2013-09-18 16:48:43]

LGTM the approach but see comment + need to file issue to clean up after M31
branch cut.

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/profiles/profile_helper.h (right):

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/profiles/profile_helper.h:67: base::FilePath
GetUserProfileDir(const std::string& user_id_hash);
As we discussed offline UserManagerImpl::GetUserProfileDir needs to be updated
too.

[Nikita (slow), 2013-09-18 18:04:37]

PTAL

+sail@ for profile_manager.cc review

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
File chrome/browser/chromeos/profiles/profile_helper.h (right):

https://codereview.chromium.org/23967015/diff/6001/chrome/browser/chromeos/pr...
chrome/browser/chromeos/profiles/profile_helper.h:67: base::FilePath
GetUserProfileDir(const std::string& user_id_hash);
On 2013/09/18 16:48:43, Dmitry Polukhin wrote:
> As we discussed offline UserManagerImpl::GetUserProfileDir needs to be updated
> too.

Done.

[Dmitry Polukhin, 2013-09-18 18:06:29]

lgtm

[sail, 2013-09-18 18:17:20]

profies/* LGTM

https://codereview.chromium.org/23967015/diff/22001/chrome/browser/profiles/p...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/23967015/diff/22001/chrome/browser/profiles/p...
chrome/browser/profiles/profile_manager.cc:320: // legacy --login-profile=user
switch and enable multi-profiles on CrOS
Normally we also include a bug number for these types of TODOs.

[Nikita (slow), 2013-09-19 08:17:34]

+nona@ for
chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc review

https://codereview.chromium.org/23967015/diff/22001/chrome/browser/profiles/p...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/23967015/diff/22001/chrome/browser/profiles/p...
chrome/browser/profiles/profile_manager.cc:320: // legacy --login-profile=user
switch and enable multi-profiles on CrOS
On 2013/09/18 18:17:20, sail wrote:
> Normally we also include a bug number for these types of TODOs.

Done.

[Seigo Nonaka, 2013-09-19 08:21:40]

lgtm

lgtm for
chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc

[commit-bot: I haz the power, 2013-09-19 11:04:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/23967015/3008

[commit-bot: I haz the power, 2013-09-19 11:17:07]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Nikita (slow), 2013-09-19 11:29:08]

+jochen@ for owner's lgtm in

chrome/common/chrome_constants.cc
chrome/common/chrome_constants.h
chrome/common/logging_chrome.cc

[jochen (gone - plz use gerrit), 2013-09-19 12:25:31]

lgtm

[commit-bot: I haz the power, 2013-09-19 12:28:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/23967015/3008

[commit-bot: I haz the power, 2013-09-19 14:39:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nkostylev@chromium.org/23967015/3008

[commit-bot: I haz the power, 2013-09-19 14:40:02]

Change committed as 224130