Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2396693004:
[wrapper-tracing] MutationObserver: Add write barriers (Closed)
|
Created:
4 years, 2 months ago by Michael Lippautz Modified:
4 years, 2 months ago CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Hannes Payer (out of office), rwlbuis, sof Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[wrapper-tracing] MutationObserver: Add write barriers
Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRkRDFwBc/edit#gid=0&vpid=A3
BUG=chromium:468240
R=haraken@chromium.org
Committed: https://crrev.com/9ce2be7adb87123b52194a9ab7d01ebf82b5d83d
Cr-Commit-Position: refs/heads/master@{#423820}
Patch Set 1 #Patch Set 2 : Fix includes #Patch Set 3 : Fix brackets #Patch Set 4 : Rebase to fix bots (?) #Patch Set 5 : Move WB below setting the flag, actually making the getter work #
Messages
Total messages: 43 (25 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [wrapper-tracing] MutationObserver: Add write barriers BUG= ========== to ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG= ==========
Description was changed from ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG= ========== to ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG=chromium:468240 R=haraken@chromium.org ==========
mlippautz@chromium.org changed reviewers: + haraken@chromium.org
mlippautz@chromium.org changed reviewers: + hlopko@chromium.org
ptal, going through the list one by one
Patchset #1 (id:20001) has been deleted
LGTM
LGTM, let's wait for Kentaro's review, too.
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by mlippautz@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, hlopko@chromium.org Link to the patchset: https://codereview.chromium.org/2396693004/#ps50001 (title: "Fix includes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, hlopko@chromium.org Link to the patchset: https://codereview.chromium.org/2396693004/#ps70001 (title: "Fix brackets")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, hlopko@chromium.org Link to the patchset: https://codereview.chromium.org/2396693004/#ps90001 (title: "Rebase to fix bots (?)")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by mlippautz@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org, hlopko@chromium.org Link to the patchset: https://codereview.chromium.org/2396693004/#ps110001 (title: "Move WB below setting the flag, actually making the getter work")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG=chromium:468240 R=haraken@chromium.org ========== to ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG=chromium:468240 R=haraken@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #5 (id:110001)
Message was sent while issue was closed.
Description was changed from ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG=chromium:468240 R=haraken@chromium.org ========== to ========== [wrapper-tracing] MutationObserver: Add write barriers Overview: https://docs.google.com/spreadsheets/d/1RhLiHF9Pnw7Zx8EijuR0LruPkeiVJIXXi0eRk... BUG=chromium:468240 R=haraken@chromium.org Committed: https://crrev.com/9ce2be7adb87123b52194a9ab7d01ebf82b5d83d Cr-Commit-Position: refs/heads/master@{#423820} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/9ce2be7adb87123b52194a9ab7d01ebf82b5d83d Cr-Commit-Position: refs/heads/master@{#423820} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
